Change in coreboot[master]: cbfstool/linux_trampoline: Fill the ACPI RSDP entry - coreboot-gerrit

3 Mar 2022


      Attention is currently required from: Arthur Heymans, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File util/cbfstool/linux_trampoline.S:
https://review.coreboot.org/c/coreboot/+/62574/comment/5d26f2fc_a57a8257 
PS4, Line 100: je .endScan
Why not a simple `jmp`? We know it's right on this path, isn't it?
(and I don't know if `mov` can have an effect on flags ._.)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment