Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85161?usp=email )
Change subject: soc/intel: Assert if `pmc_/gpe0_dwX` values are not unique
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
FYI, this breaks a ton of devices which use the default GPE routing, which previously worked fine but now assert since no routes defined in devicetree
HI Matt,
Can you help me understand how this affects you? If, as you say, lots of devices are failing due to static assertions, why did the build-bots mark this CL as V+1? Shouldn't a static assertion cause the build to fail?
Suggestion, if you are thinking avoiding assertion check for undeclared GPE (with default value 0) is good enough ? But note, as per GPE PMC description, zero is also a valid GPE group assignment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85161?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b4f2f90a858b9ec85145bce0542f1ce61d080be
Gerrit-Change-Number: 85161
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Mon, 27 Jan 2025 02:34:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com