Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 )
Change subject: mb/google/myst: First pass GPIO configuration for Myst ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74095/comment/3d5080b9_c6cbd415 PS7, Line 60: HIGH) Active High. So please leave it as LOW.
https://review.coreboot.org/c/coreboot/+/74095/comment/b07eb643_276f6550 PS7, Line 64: HIGH Active High. So please leave it as LOW.
https://review.coreboot.org/c/coreboot/+/74095/comment/7f47989b_00a5422c PS7, Line 75: /* SOC_MEM_VID_C1 */ : PAD_GPI(GPIO_42, PULL_NONE), This should also be configured by SMU and not touched by coreboot.
-
Karthik Ramasubramanian (Code Review)