Attention is currently required from: Daniel Kurtz, Kevin Chang, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56100 )
Change subject: grunt/treeya: add Realtek ALC5682 codec support
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/kahlee/variants/treeya/audio.c:
https://review.coreboot.org/c/coreboot/+/56100/comment/c775406c_7d75411b
PS2, Line 22: 0xfedc2000
Can you define a macro for this?
https://review.coreboot.org/c/coreboot/+/56100/comment/9187f9cb_f4a648f9
PS2, Line 24: }
Can one of the checks be moved into the do-while condition?
```
do {
mmio_dev = dev_find_path(mmio_dev, DEVICE_PATH_MMIO);
if (mmio_dev == NULL)
break;
} while (mmio_dev->path.mmio.addr != 0xfedc2000);
```
https://review.coreboot.org/c/coreboot/+/56100/comment/ca9ca20c_25c3d9e8
PS2, Line 27: return;
Can’t you return already above? Maybe also print an error?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49c673fd944b2c2a79c4283eee941a16596ba7fa
Gerrit-Change-Number: 56100
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 09:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment