Attention is currently required from: Shelley Chen. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Add strict flag to clock_configure() ......................................................................
Patch Set 4:
(3 comments)
File src/soc/qualcomm/common/include/soc/clock_common.h:
https://review.coreboot.org/c/coreboot/+/63289/comment/38749325_a9be3c54 PS4, Line 151: highest nit: "higher"?
File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/d396730f_b52754c5 PS4, Line 218: &mdss_clk_cfg, 0, 0, false); nit: looking at how this works (which is a little haphazard anyway... basically just building a fake array of one element and passing 0 size to force skip the for loop) I think you wouldn't actually need to disable the strict check here, since hz == 0 matches the fake entry. So maybe you don't need the strict parameter after all?
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/69ed7431_ead6ab1e PS4, Line 311: false Why can't these be checked?
-
Julius Werner (Code Review)