Change in coreboot[master]: mb/*/*/acpi: Convert sata.asl to ASL 2.0 syntax - coreboot-gerrit

4 Oct 2020

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46024 )
Change subject: mb/*/*/acpi: Convert sata.asl to ASL 2.0 syntax
......................................................................
mb/*/*/acpi: Convert sata.asl to ASL 2.0 syntax
Change-Id: Id12c2cd955a778101b3aee7f37103adeb4173bb3
Signed-off-by: Elyes HAOUAS ehaouas@noos.fr
---
M src/mainboard/amd/inagua/acpi/sata.asl
M src/mainboard/amd/persimmon/acpi/sata.asl
M src/mainboard/amd/south_station/acpi/sata.asl
M src/mainboard/amd/union_station/acpi/sata.asl
M src/mainboard/asrock/e350m1/acpi/sata.asl
M src/mainboard/asus/am1i-a/acpi/sata.asl
M src/mainboard/biostar/am1ml/acpi/sata.asl
M src/mainboard/elmex/pcm205400/acpi/sata.asl
M src/mainboard/gizmosphere/gizmo/acpi/sata.asl
M src/mainboard/jetway/nf81-t56n-lf/acpi/sata.asl
M src/mainboard/pcengines/apu1/acpi/sata.asl
11 files changed, 132 insertions(+), 132 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46024/1

diff --git a/src/mainboard/amd/inagua/acpi/sata.asl b/src/mainboard/amd/inagua/acpi/sata.asl
index 9344ff1..e924b57 100644
--- a/src/mainboard/amd/inagua/acpi/sata.asl
+++ b/src/mainboard/amd/inagua/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -70,7 +70,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -83,7 +83,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -97,35 +97,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/amd/persimmon/acpi/sata.asl b/src/mainboard/amd/persimmon/acpi/sata.asl
index 9344ff1..e924b57 100644
--- a/src/mainboard/amd/persimmon/acpi/sata.asl
+++ b/src/mainboard/amd/persimmon/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -70,7 +70,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -83,7 +83,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -97,35 +97,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/amd/south_station/acpi/sata.asl b/src/mainboard/amd/south_station/acpi/sata.asl
index 9344ff1..e924b57 100644
--- a/src/mainboard/amd/south_station/acpi/sata.asl
+++ b/src/mainboard/amd/south_station/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -70,7 +70,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -83,7 +83,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -97,35 +97,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/amd/union_station/acpi/sata.asl b/src/mainboard/amd/union_station/acpi/sata.asl
index 9344ff1..e924b57 100644
--- a/src/mainboard/amd/union_station/acpi/sata.asl
+++ b/src/mainboard/amd/union_station/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -70,7 +70,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -83,7 +83,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -97,35 +97,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/asrock/e350m1/acpi/sata.asl b/src/mainboard/asrock/e350m1/acpi/sata.asl
index 7f305fb..6d9ff03 100644
--- a/src/mainboard/asrock/e350m1/acpi/sata.asl
+++ b/src/mainboard/asrock/e350m1/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -71,7 +71,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -84,7 +84,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -98,35 +98,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/asus/am1i-a/acpi/sata.asl b/src/mainboard/asus/am1i-a/acpi/sata.asl
index 84cc348..27e5222 100644
--- a/src/mainboard/asus/am1i-a/acpi/sata.asl
+++ b/src/mainboard/asus/am1i-a/acpi/sata.asl
@@ -22,7 +22,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -35,7 +35,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -57,7 +57,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -70,7 +70,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -84,35 +84,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/biostar/am1ml/acpi/sata.asl b/src/mainboard/biostar/am1ml/acpi/sata.asl
index d1a4ee7..31b9374 100644
--- a/src/mainboard/biostar/am1ml/acpi/sata.asl
+++ b/src/mainboard/biostar/am1ml/acpi/sata.asl
@@ -33,7 +33,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -46,7 +46,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -68,7 +68,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -81,7 +81,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -95,35 +95,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/elmex/pcm205400/acpi/sata.asl b/src/mainboard/elmex/pcm205400/acpi/sata.asl
index 7f305fb..6d9ff03 100644
--- a/src/mainboard/elmex/pcm205400/acpi/sata.asl
+++ b/src/mainboard/elmex/pcm205400/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -71,7 +71,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -84,7 +84,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -98,35 +98,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/gizmosphere/gizmo/acpi/sata.asl b/src/mainboard/gizmosphere/gizmo/acpi/sata.asl
index 7f305fb..6d9ff03 100644
--- a/src/mainboard/gizmosphere/gizmo/acpi/sata.asl
+++ b/src/mainboard/gizmosphere/gizmo/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -71,7 +71,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -84,7 +84,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -98,35 +98,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/sata.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/sata.asl
index 7f305fb..6d9ff03 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi/sata.asl
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -71,7 +71,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -84,7 +84,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -98,35 +98,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
diff --git a/src/mainboard/pcengines/apu1/acpi/sata.asl b/src/mainboard/pcengines/apu1/acpi/sata.asl
index 7f305fb..6d9ff03 100644
--- a/src/mainboard/pcengines/apu1/acpi/sata.asl
+++ b/src/mainboard/pcengines/apu1/acpi/sata.asl
@@ -35,7 +35,7 @@
    Device(PMST) {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P0IS,0)) {
+			if (P0IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -48,7 +48,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P1IS,0)) {
+			if (P1IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -71,7 +71,7 @@
    {
    	Name(_ADR, 0)
    	Method(_STA,0) {
-			if (LGreater(P2IS,0)) {
+			if (P2IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -84,7 +84,7 @@
    {
    	Name(_ADR, 1)
    	Method(_STA,0) {
-			if (LGreater(P3IS,0)) {
+			if (P3IS > 0) {
    			return (0x0F) /* sata is visible */
    		}
    		else {
@@ -98,35 +98,35 @@
 Scope(_GPE) {
    Method(_L1F,0x0,NotSerialized) {
    	if (_SB.P0PR) {
-			if (LGreater(_SB.P0IS,0)) {
+			if (_SB.P0IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P0PR)
+			 _SB.P0PR = 1
    	}
if (_SB.P1PR) {
-			if (LGreater(_SB.P1IS,0)) {
+			if (_SB.P1IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P1PR)
+			_SB.P1PR = 1
    	}
if (_SB.P2PR) {
-			if (LGreater(_SB.P2IS,0)) {
+			if (_SB.P2IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P2PR)
+			_SB.P2PR = 1
    	}
if (_SB.P3PR) {
-			if (LGreater(_SB.P3IS,0)) {
+			if (_SB.P3IS > 0) {
    			sleep(32)
    		}
    		Notify(_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */
-			store(one, _SB.P3PR)
+			_SB.P3PR = 1
    	}
    }
 }
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/46024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id12c2cd955a778101b3aee7f37103adeb4173bb3
Gerrit-Change-Number: 46024
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: newchange



    