Change in coreboot[master]: ec/google/wilco: Add placeholder methods for privacy screen

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Mathew King (Code Review)

14 Oct 2019 14 Oct '19

11:14 a.m.

Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add placeholder methods for privacy screen ......................................................................

ec/google/wilco: Add placeholder methods for privacy screen

Add placeholder ACPI methods to the Wilco EC for controlling a privacy screen on the device. These methods will be updteded when the EC has commands to control the screen.

BUG=b:142237145, b:142656363 TEST=none

Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Signed-off-by: Mathew King mathewk@chromium.org --- M src/ec/google/wilco/acpi/ec.asl A src/ec/google/wilco/acpi/privacy.asl 2 files changed, 28 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/1

diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl index 532f421..8fcd0dd 100644 --- a/src/ec/google/wilco/acpi/ec.asl +++ b/src/ec/google/wilco/acpi/ec.asl @@ -178,4 +178,7 @@ #ifdef EC_ENABLE_DPTF #include "dptf.asl" #endif +#ifdef EC_ENABLE_PRIVACY + #include "privacy.asl" +#endif } diff --git a/src/ec/google/wilco/acpi/privacy.asl b/src/ec/google/wilco/acpi/privacy.asl new file mode 100644 index 0000000..2121d23 --- /dev/null +++ b/src/ec/google/wilco/acpi/privacy.asl @@ -0,0 +1,25 @@ +/* Read Privacy Screen Present */ +Method (GPVD, 0, Serialized) +{ + Printf ("Read Privacy Screen Present") + Return (One) +} + +/* Read Privacy Screen Status */ +Method (GPVX, 0, Serialized) +{ + Printf ("Read Privacy Screen Status") + Return (0x0) +} + +/* Enable Privacy Screen */ +Method (EPVX, 0, Serialized) +{ + Printf ("Enable Privacy Screen") +} + +/* Disable Privacy Screen */ +Method (DPVX, 0, Serialized) +{ + Printf ("Disable Privacy Screen") +} \ No newline at end of file

Attachments:

attachment.htm (text/html — 4.7 KB)

Show replies by date

Mathew King (Code Review)

14 Oct 14 Oct

12:38 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36044

to look at the new patch set (#3).

Change subject: ec/google/wilco: Add placeholder methods for privacy screen ......................................................................

ec/google/wilco: Add placeholder methods for privacy screen

Add placeholder ACPI methods to the Wilco EC for controlling a privacy screen on the device. These methods will be updteded when the EC has commands to control the screen.

BUG=b:142237145, b:142656363 TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/3

Mathew King (Code Review)

12:53 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36044

to look at the new patch set (#5).

Change subject: ec/google/wilco: Add placeholder methods for privacy screen ......................................................................

ec/google/wilco: Add placeholder methods for privacy screen

Add placeholder ACPI methods to the Wilco EC for controlling a privacy screen on the device. These methods will be updteded when the EC has commands to control the screen.

BUG=b:142237145, b:142656363 TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/5

Mathew King (Code Review)

3:09 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36044

to look at the new patch set (#6).

Change subject: ec/google/wilco: Add placeholder methods for privacy screen ......................................................................

ec/google/wilco: Add placeholder methods for privacy screen

Add placeholder ACPI methods to the Wilco EC for controlling a privacy screen on the device. These methods will be updteded when the EC has commands to control the screen.

BUG=b:142237145, b:142656363 TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/6

Mathew King (Code Review)

4 Nov 4 Nov

4:17 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36044

to look at the new patch set (#10).

Change subject: ec/google/wilco: Add placeholder methods for privacy screen ......................................................................

ec/google/wilco: Add placeholder methods for privacy screen

Add placeholder ACPI methods to the Wilco EC for controlling a privacy screen on the device. These methods will be updteded when the EC has commands to control the screen.

BUG=b:142237145, b:142656363 TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/10

Duncan Laurie (Code Review)

5 Nov 5 Nov

1:43 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add placeholder methods for privacy screen ......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36044/10/src/ec/google/wilco/acpi/p... File src/ec/google/wilco/acpi/privacy.asl:

https://review.coreboot.org/c/coreboot/+/36044/10/src/ec/google/wilco/acpi/p... PS10, Line 20: Tab indents

https://review.coreboot.org/c/coreboot/+/36044/10/src/ec/google/wilco/acpi/p... PS10, Line 28: 0x0 could use "Zero"

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 10 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Tue, 05 Nov 2019 21:43:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mathew King (Code Review)

6 Nov 6 Nov

3:46 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36044

to look at the new patch set (#11).

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

ec/google/wilco: Add EC ACPI methods for privacy screen

Add ACPI methods to the Wilco EC for controlling a privacy screen on the device.

BUG=b:142237145, b:142656363 TEST=none

Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Signed-off-by: Mathew King mathewk@chromium.org --- M src/ec/google/wilco/acpi/ec.asl M src/ec/google/wilco/acpi/ec_ram.asl A src/ec/google/wilco/acpi/privacy.asl 3 files changed, 51 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/11

Mathew King (Code Review)

3:48 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36044/10/src/ec/google/wilco/acpi/p... File src/ec/google/wilco/acpi/privacy.asl:

https://review.coreboot.org/c/coreboot/+/36044/10/src/ec/google/wilco/acpi/p... PS10, Line 20:

...

Tab indents

Done

https://review.coreboot.org/c/coreboot/+/36044/10/src/ec/google/wilco/acpi/p... PS10, Line 28: 0x0

...

could use "Zero"

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 11 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Wed, 06 Nov 2019 23:48:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org Gerrit-MessageType: comment

Simon Glass (Code Review)

2 Dec 2 Dec

2:52 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

Patch Set 13: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36044/13/src/ec/google/wilco/acpi/e... File src/ec/google/wilco/acpi/ec_ram.asl:

https://review.coreboot.org/c/coreboot/+/36044/13/src/ec/google/wilco/acpi/e... PS13, Line 130: Drop extra blank line?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 13 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Mon, 02 Dec 2019 22:52:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mathew King (Code Review)

3:07 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Hello Simon Glass, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36044

to look at the new patch set (#14).

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

ec/google/wilco: Add EC ACPI methods for privacy screen

Add ACPI methods to the Wilco EC for controlling a privacy screen on the device.

BUG=b:142237145, b:142656363 TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36044/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 14 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-MessageType: newpatchset

Mathew King (Code Review)

3:09 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36044/13/src/ec/google/wilco/acpi/e... File src/ec/google/wilco/acpi/ec_ram.asl:

https://review.coreboot.org/c/coreboot/+/36044/13/src/ec/google/wilco/acpi/e... PS13, Line 130:

...

Drop extra blank line?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 14 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Mon, 02 Dec 2019 23:09:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Glass sjg@chromium.org Gerrit-MessageType: comment

Simon Glass (Code Review)

3:09 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

Patch Set 14: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 14 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Mon, 02 Dec 2019 23:09:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

3:24 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

Patch Set 14:

Not sure why jenkins isn't running against this patch...

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 14 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Mon, 02 Dec 2019 23:24:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mathew King (Code Review)

3:27 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

Patch Set 14:

...

Patch Set 14:

Not sure why jenkins isn't running against this patch...

There it goes!

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 14 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-Comment-Date: Mon, 02 Dec 2019 23:27:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

3:28 p.m.

New subject: Change in coreboot[master]: ec/google/wilco: Add EC ACPI methods for privacy screen

Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36044 )

Change subject: ec/google/wilco: Add EC ACPI methods for privacy screen ......................................................................

ec/google/wilco: Add EC ACPI methods for privacy screen

Add ACPI methods to the Wilco EC for controlling a privacy screen on the device.

BUG=b:142237145, b:142656363 TEST=none

Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Signed-off-by: Mathew King mathewk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36044 Reviewed-by: Simon Glass sjg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/wilco/acpi/ec.asl M src/ec/google/wilco/acpi/ec_ram.asl A src/ec/google/wilco/acpi/privacy.asl 3 files changed, 50 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Simon Glass: Looks good to me, approved

Name (ESGN, Package () { 0x5c, 0xff, RD }) /* Indicate EC uses signed FW */

+Name (EPDT, Package () { 0x5d, 0xff, RD }) /* Privacy Screen Detection */ +Name (EPST, Package () { 0x5e, 0xff, RD }) /* Privacy Screen State */ + /* * EC RAM WRITE */ @@ -135,6 +138,7 @@ Name (ERDY, Package () { 0x05, 0xff, WR }) /* EC Ready */ Name (FWAK, Package () { 0x06, 0xff, WR }) /* EC _WAK */ Name (PS2M, Package () { 0x20, 0xff, WR }) /* EC PS/2 Mouse Emulation */ +Name (EPCT, Package () { 0x25, 0xff, WR }) /* Privacy Screen Control */ Name (DWST, Package () { 0x32, 0xff, WR }) /* DPTF: Write State */ Name (DWTI, Package () { 0x33, 0xff, WR }) /* DPTF: Write Thermal Index */ Name (DWTL, Package () { 0x35, 0xff, WR }) /* DPTF: Write Trip Low */ diff --git a/src/ec/google/wilco/acpi/privacy.asl b/src/ec/google/wilco/acpi/privacy.asl new file mode 100644 index 0000000..5c620b0 --- /dev/null +++ b/src/ec/google/wilco/acpi/privacy.asl @@ -0,0 +1,43 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Google LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* Read Privacy Screen Present */ +Method (GPVD, 0, Serialized) +{ + Return (R (EPDT)) +} + +/* Read Privacy Screen Status */ +Method (GPVX, 0, Serialized) +{ + If (R (EPST) == Zero) { + Return (Zero) + } + + Return (One) +} + +/* Enable Privacy Screen */ +Method (EPVX, 0, Serialized) +{ + W (EPCT, One) +} + +/* Disable Privacy Screen */ +Method (DPVX, 0, Serialized) +{ + W (EPCT, Zero) +}

-- To view, visit https://review.coreboot.org/c/coreboot/+/36044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3c136f9d2de90eeb3c9e468e4c7430ccf6dcc42 Gerrit-Change-Number: 36044 Gerrit-PatchSet: 15 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1812

days inactive

1861

days old

coreboot-gerrit@coreboot.org

14 comments

3 participants

tags (0)

participants (3)

Duncan Laurie (Code Review)
Mathew King (Code Review)
Simon Glass (Code Review)