Change in coreboot[master]: mb/kontron/mal10: Remove unnecessary includes

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Singer (Code Review)

30 Nov 2020 30 Nov '20

8:59 a.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

mb/kontron/mal10: Remove unnecessary includes

Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 --- M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48144/1

diff --git a/src/mainboard/kontron/mal10/ramstage.c b/src/mainboard/kontron/mal10/ramstage.c index 87ead15..f03006a 100644 --- a/src/mainboard/kontron/mal10/ramstage.c +++ b/src/mainboard/kontron/mal10/ramstage.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <soc/ramstage.h> #include <carrier/gpio.h> -#include <stddef.h>

static void init_mainboard(void *chip_info) { diff --git a/src/mainboard/kontron/mal10/romstage.c b/src/mainboard/kontron/mal10/romstage.c index 9f1d7eb..dba78f7 100644 --- a/src/mainboard/kontron/mal10/romstage.c +++ b/src/mainboard/kontron/mal10/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h> #include <soc/romstage.h> #include <FspmUpd.h>

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Felix Singer (Code Review)

30 Nov 30 Nov

9:05 a.m.

Hello Nico Huber, Maxim Polyakov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48144

to look at the new patch set (#2).

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

mb/kontron/mal10: Remove unnecessary includes

Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 --- M src/mainboard/kontron/mal10/include/carrier/gpio.h M src/mainboard/kontron/mal10/include/variant/gpio.h M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 4 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48144/2

Frans Hendriks (Code Review)

9:56 a.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 30 Nov 2020 08:56:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

10:28 a.m.

Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Maxim Polyakov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48144

to look at the new patch set (#4).

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

mb/kontron/mal10: Remove unnecessary includes

Built with BUILD_TIMELESS=1, coreboot.rom remains the same.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48144/4

Felix Singer (Code Review)

4 Jan 4 Jan

9:53 p.m.

Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Maxim Polyakov, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48144

to look at the new patch set (#8).

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

mb/kontron/mal10: Remove unnecessary includes

Built with BUILD_TIMELESS=1, coreboot.rom remains the same.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48144/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

5 Jan 5 Jan

12:52 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/carrier/gpio.h:

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h> uhm... that's definitely wrong lol. "soc/gpio.h" should be used here. suggestion: rename the commit to "Clean up includes" and just do fix that. no new change needed :)

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h> not needed here

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Jan 2021 23:52:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:52 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

Patch Set 9: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Jan 2021 23:52:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:56 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/carrier/gpio.h:

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h>

...

uhm... that's definitely wrong lol. "soc/gpio.h" should be used here. […]

oh well, it fits better in "use explicit includes", ignore that one here

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Jan 2021 23:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: comment

Felix Singer (Code Review)

12:58 a.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h>

...

not needed here

It's not needed here, but in the C files which include this. I move such includes around in CB:48145.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Jan 2021 23:58:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

1:01 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

Patch Set 9: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h>

...

It's not needed here, but in the C files which include this. […]

ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 05 Jan 2021 00:01:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

1:02 a.m.

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48144 )

Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................

mb/kontron/mal10: Remove unnecessary includes

Built with BUILD_TIMELESS=1, coreboot.rom remains the same.

Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48144 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/kontron/mal10/include/carrier/gpio.h M src/mainboard/kontron/mal10/include/variant/gpio.h M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 4 files changed, 0 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/kontron/mal10/include/carrier/gpio.h b/src/mainboard/kontron/mal10/include/carrier/gpio.h index b8606f6..9466b24 100644 --- a/src/mainboard/kontron/mal10/include/carrier/gpio.h +++ b/src/mainboard/kontron/mal10/include/carrier/gpio.h @@ -4,7 +4,6 @@ #define CARRIER_GPIO_H

#include <gpio.h> -#include <stddef.h>

/* * Bidirectional GPIO port when both RX and TX buffer is enabled diff --git a/src/mainboard/kontron/mal10/include/variant/gpio.h b/src/mainboard/kontron/mal10/include/variant/gpio.h index 99cf35a..a3ff7c0 100644 --- a/src/mainboard/kontron/mal10/include/variant/gpio.h +++ b/src/mainboard/kontron/mal10/include/variant/gpio.h @@ -4,7 +4,6 @@ #define VARIANT_GPIO_H

#include <gpio.h> -#include <stddef.h>

void variant_early_gpio_configure(void);

diff --git a/src/mainboard/kontron/mal10/ramstage.c b/src/mainboard/kontron/mal10/ramstage.c index 48194e6..3d259d8 100644 --- a/src/mainboard/kontron/mal10/ramstage.c +++ b/src/mainboard/kontron/mal10/ramstage.c @@ -2,7 +2,6 @@

#include <soc/ramstage.h> #include <carrier/gpio.h> -#include <stddef.h>

void mainboard_silicon_init_params(FSP_S_CONFIG *silconfig) { diff --git a/src/mainboard/kontron/mal10/romstage.c b/src/mainboard/kontron/mal10/romstage.c index 9f1d7eb..dba78f7 100644 --- a/src/mainboard/kontron/mal10/romstage.c +++ b/src/mainboard/kontron/mal10/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h> #include <soc/romstage.h> #include <FspmUpd.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1418

days inactive

1454

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Felix Singer (Code Review)
Frans Hendriks (Code Review)
Michael Niewöhner (Code Review)