Attention is currently required from: Kangheui Won, Chen Wisley, Reka Norman, Tim Wawrzynczak, Shou-Chieh Hsu.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68082 )
Change subject: mb/google/nissa/var/yaviks: Config I2C frequency
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68082/comment/0b36b00d_efaa0b33
PS5, Line 11: I2C0: TPM: 997.7 Khz
: I2C1: Touchscreen: 392.6 Khz
: I2C3: Audio: 394.9 Khz
: I2C5: Touchpad: 391.6 Khz
nit: no need to duplicate these
Done
File src/mainboard/google/brya/variants/yaviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68082/comment/0a3bf354_b6243518
PS5, Line 46: 55
OK,we will revise and measure again.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68082
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33c2891f17bc3c572bbfcbf30bbbdef9eb850ce7
Gerrit-Change-Number: 68082
Gerrit-PatchSet: 6
Gerrit-Owner: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Wed, 05 Oct 2022 02:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-MessageType: comment