Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59844 )
Change subject: soc/intel/common/systemagent: Remove weak functions ......................................................................
soc/intel/common/systemagent: Remove weak functions
All socs implement this and an useful implementation is expected so remove weak definitions.
Change-Id: I773311ef6f8d98441ce461343066f8b25c741fbc Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/systemagent/systemagent.c 1 file changed, 0 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/59844/1
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index b7c6d4f..63c2e14 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -17,37 +17,6 @@ #include <types.h> #include "systemagent_def.h"
-/* SoC override function */ -__weak void soc_systemagent_init(struct device *dev) -{ - /* no-op */ -} - -__weak void soc_add_fixed_mmio_resources(struct device *dev, - int *resource_cnt) -{ - /* no-op */ -} - -__weak int soc_get_uncore_prmmr_base_and_mask(uint64_t *base, - uint64_t *mask) -{ - /* return failure for this dummy API */ - return -1; -} - -__weak unsigned long sa_write_acpi_tables(const struct device *dev, - unsigned long current, - struct acpi_rsdp *rsdp) -{ - return current; -} - -__weak uint32_t soc_systemagent_max_chan_capacity_mib(u8 capid0_a_ddrsz) -{ - return 32768; /* 32 GiB per channel */ -} - static uint8_t sa_get_ecc_type(const uint32_t capid0_a) { return capid0_a & CAPID_ECCDIS ? MEMORY_ARRAY_ECC_NONE : MEMORY_ARRAY_ECC_SINGLE_BIT;