Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49134 )
Change subject: mb/google/dedede: Enable "FastPkgCRampDisable" upd for noise mitigation ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49134/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49134/5//COMMIT_MSG@17 PS5, Line 17: correct value has been programmed and slew rate measurement : is correct on scope. What about the noise?
https://review.coreboot.org/c/coreboot/+/49134/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/49134/5/src/mainboard/google/dedede... PS5, Line 70: 1 Can you please add enums for this in chip.h? I think it is much simpler to read and understand what the settings are.