Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74742 )
Change subject: util/cbmem: Add REG_NEWLINE flag to fix matching pattern
......................................................................
Patch Set 2:
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/74742/comment/ded5ef66_5458e964
PS2, Line 1010: match.rm_so + 1;
Why do we move the cursor to match.rm_so + 1 instead of match.rm_eo?
If we had moved the cursor to match.rm_eo, would we have caught the bug earlier. We would have matched the whole log and the cursor might be pointing to NULL character. cbmem -1 would have broken too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e924349ead0fa7eea8b9ad5161138a4c4946ade
Gerrit-Change-Number: 74742
Gerrit-PatchSet: 2
Gerrit-Owner: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Apr 2023 01:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment