Attention is currently required from: Jason Nien, EricKY Cheng, Martin Roth, Karthikeyan Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67209 )
Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings
......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/google/skyrim/variants/winterhold/gpio.c:
https://review.coreboot.org/c/coreboot/+/67209/comment/d6259396_c14c6932
PS4, Line 10: // NC
Remove these extra comments. The PAD_NC already makes it clear
https://review.coreboot.org/c/coreboot/+/67209/comment/81818e82_6d167530
PS4, Line 22: /* CLK_REQ1_L / EMMC */
How about this?
https://review.coreboot.org/c/coreboot/+/67209/comment/b5681c41_8949e17e
PS4, Line 25: __weak
You don't want to make this weak
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc
Gerrit-Change-Number: 67209
Gerrit-PatchSet: 4
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment