Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39196 )
Change subject: jasperlake_rvp: UART config for JSLRVP ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jasper... PS11, Line 14: BOARD_INTEL_JASPERLAKE_RVP
@Maulik, i don't think this assumption is valid even inside chrome team? […]
@Subrata. It was to differentiate between 2 variants. JSLRVP would use legacy UART while External EC boards would use LPSS. Both UART won't get selected in single build. Sorry for confusion, I have handled in cleanly in my patch here: https://review.coreboot.org/c/coreboot/+/39584
https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jasper... PS11, Line 53: default 0 if !INTEL_LPSS_UART_FOR_CONSOLE
this is good idea to support both UART is same build bt technically its not possible […]
@Subrata, we use 8250IO in case of jasper Lake RVP boards. We can remove this patch itself since I have corrected it in my another patch.
-
Maulik V Vaghela (Code Review)