Change in coreboot[master]: mb/google/hatch/variants/helios: Fix leakage voltage problem on touch...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kane Chen (Code Review)

8 Nov 2019 8 Nov '19

9:19 a.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen

Set GPP_C4 default to low to fix leakage voltage problem on touchscreen during power on.

BUG=b:142368161 BRANCH=Master TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure touchscreen works.

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 --- M src/mainboard/google/hatch/variants/helios/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/36670/1

diff --git a/src/mainboard/google/hatch/variants/helios/gpio.c b/src/mainboard/google/hatch/variants/helios/gpio.c index bebcf32..85eb3fc 100644 --- a/src/mainboard/google/hatch/variants/helios/gpio.c +++ b/src/mainboard/google/hatch/variants/helios/gpio.c @@ -33,6 +33,8 @@ PAD_NC(GPP_B19, NONE), /* C1 : SMBDATA ==> NC */ PAD_NC(GPP_C1, NONE), + /* C4 : TOUCHSCREEN_DIS_L */ + PAD_CFG_GPO(GPP_C4, 0, DEEP), /* C6 : GPP_C6 ==> NC */ PAD_NC(GPP_C6, NONE), /* C7 : GPP_C7 ==> NC */

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Kane Chen (Code Review)

8 Nov 8 Nov

9:29 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Fri, 08 Nov 2019 08:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:15 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36670/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36670/1//COMMIT_MSG@13 PS1, Line 13: rammus hatch?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 08 Nov 2019 16:15:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ken Lu (Code Review)

11 Nov 11 Nov

3:03 a.m.

Ken Lu has uploaded a new patch set (#2) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen

Set GPP_C4 default to low to fix leakage voltage problem on touchscreen during power on.

BUG=b:142368161 BRANCH=Master TEST=emerge-hatch coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure touchscreen works.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/36670/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

5:37 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Mon, 11 Nov 2019 16:37:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

12 Nov 12 Nov

1:33 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Tue, 12 Nov 2019 00:33:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ken Lu (Code Review)

13 Nov 13 Nov

3:27 a.m.

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36670/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36670/1//COMMIT_MSG@13 PS1, Line 13: rammus

...

hatch?

Correct the type error .

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 02:27:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Subrata Banik (Code Review)

6:02 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 05:02:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

6:02 a.m.

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36670 )

Change subject: mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen ......................................................................

mb/google/hatch/variants/helios: Fix leakage voltage problem on touchscreen

Set GPP_C4 default to low to fix leakage voltage problem on touchscreen during power on.

BUG=b:142368161 BRANCH=Master TEST=emerge-hatch coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure touchscreen works.

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36670 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/helios/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Shelley Chen: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/36670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9197192c9d6dfb30c10559990c6010b1b2d3a45 Gerrit-Change-Number: 36670 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-MessageType: merged

1777

days inactive

1782

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Kane Chen (Code Review)
Ken Lu (Code Review)
Shelley Chen (Code Review)
Subrata Banik (Code Review)
Tim Wawrzynczak (Code Review)