[XL] Change in coreboot[main]: mb/google/brox: Create new Brox baseboard - coreboot-gerrit

10 Oct 2023


      Attention is currently required from: Shelley Chen.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email )
Change subject: mb/google/brox: Create new Brox baseboard
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brox/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78009/comment/fc2b7336_49d89349 :
PS5, Line 18: subdirs-y += variants/$(VARIANT_DIR)/memory
It looks like the memory directory was deleted from this CL as opposed to reduced to empty shell files.  Will that cause issue with this if the memory folder does not exist?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78009?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I929b465646ac4c69d4bab33ce23848c7b1fa0f98
Gerrit-Change-Number: 78009
Gerrit-PatchSet: 5
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Comment-Date: Tue, 10 Oct 2023 16:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment