Change in coreboot[master]: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E

[Chen Wisley (Code Review)]

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

mb/google/volteer/var/elemi: enable Genesys Logic GL9763E

Enable Genesys GL9763E as pci to emmc bridge.

BUG=b:171467336
TEST=emerge-volteer coreboot

Signed-off-by: Wisley Chen 
Change-Id: I858c12151df5b6fc19132869317edfa1b090335d
---
M src/mainboard/google/volteer/Kconfig.name
M src/mainboard/google/volteer/variants/elemi/overridetree.cb
2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/47040/1

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index 908c55b..851f563 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -73,3 +73,4 @@
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
    select USE_CAR_NEM_ENHANCED_V2
+	select DRIVERS_GENESYSLOGIC_GL9763E
diff --git a/src/mainboard/google/volteer/variants/elemi/overridetree.cb b/src/mainboard/google/volteer/variants/elemi/overridetree.cb
index 2139ad7..5f3bf86 100644
--- a/src/mainboard/google/volteer/variants/elemi/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/elemi/overridetree.cb
@@ -6,6 +6,13 @@
    register "IomTypeCPortPadCfg[0]" = "0x090E000A"
    register "IomTypeCPortPadCfg[1]" = "0x090E000D"

+        # Enable EMMC PCIE 5 using clk 5
+        register "PcieRpEnable[4]" = "1"
+        register "PcieRpLtrEnable[4]" = "1"
+        register "PcieRpHotPlug[4]" = "1"
+        register "PcieClkSrcUsage[5]" = "4"
+        register "PcieClkSrcClkReq[5]" = "4"
+
    #+-------------------+---------------------------+
    #| Field             |  Value                    |
    #+-------------------+---------------------------+
@@ -109,6 +116,7 @@
    			device generic 0 on end
    		end
    	end
+		device ref pcie_rp5 on end
    	device ref pmc hidden
    		# The pmc_mux chip driver is a placeholder for the
    		# PMC.MUX device in the ACPI hierarchy.

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 4:

This change is ready for review.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47040/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47040/4//COMMIT_MSG@9 
PS4, Line 9: pci to emmc
PCI-to-eMMC

https://review.coreboot.org/c/coreboot/+/47040/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47040/4/src/mainboard/google/voltee... 
PS4, Line 85: DRIVERS_GENESYSLOGIC_GL9763E
This can go in the Kconfig file, under `DRIVERS_GENERIC_MAX98357A`, other variants may use the bridge chip too

[Chen Wisley (Code Review)]

Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47040

to look at the new patch set (#5).

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

mb/google/volteer/var/elemi: enable Genesys Logic GL9763E

Enable Genesys GL9763E as PCI-to-eMMC bridge.

BUG=b:171467336
BRANCH=volteer
TEST=emerge-volteer coreboot

Signed-off-by: Wisley Chen 
Change-Id: I858c12151df5b6fc19132869317edfa1b090335d
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/variants/elemi/overridetree.cb
2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/47040/5

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47040/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47040/4//COMMIT_MSG@9 
PS4, Line 9: pci to emmc
> PCI-to-eMMC

Done, thanks

https://review.coreboot.org/c/coreboot/+/47040/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47040/4/src/mainboard/google/voltee... 
PS4, Line 85: DRIVERS_GENESYSLOGIC_GL9763E
> This can go in the Kconfig file, under `DRIVERS_GENERIC_MAX98357A`, other variants may use the bridg […]

Done, thanks

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47040/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47040/3/src/mainboard/google/voltee... 
PS3, Line 85: select DRIVERS_GENES
Sorry I wasn't clear, this belongs here: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... in the volteer/Kconfig, not the Kconfig.name; it doesn't hurt anything to leave it selected for all variants, the linker will remove the unused driver code.

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47040/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47040/3/src/mainboard/google/voltee... 
PS3, Line 85: select DRIVERS_GENES
> Sorry I wasn't clear, this belongs here: https://review.coreboot. […]

Hi Tim,

so, I need to move back to Kconfig.name or keep in Kconfig as patchset5

Thanks.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 5: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 5: Code-Review+2

Sorry Wisley, missed the new patchset, been reviewing a lot of patches lately....

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47040/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47040/3/src/mainboard/google/voltee... 
PS3, Line 85: select DRIVERS_GENES
> Hi Tim, […]

Ack

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47040 )

Change subject: mb/google/volteer/var/elemi: enable Genesys Logic GL9763E
......................................................................

mb/google/volteer/var/elemi: enable Genesys Logic GL9763E

Enable Genesys GL9763E as PCI-to-eMMC bridge.

BUG=b:171467336
BRANCH=volteer
TEST=emerge-volteer coreboot

Signed-off-by: Wisley Chen 
Change-Id: I858c12151df5b6fc19132869317edfa1b090335d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47040
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/variants/elemi/overridetree.cb
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, but someone else must approve
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 07a5fde..1553a3a 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -3,6 +3,7 @@
    select BOARD_ROMSIZE_KB_32768
    select DRIVERS_GENERIC_GPIO_KEYS
    select DRIVERS_GENERIC_MAX98357A
+	select DRIVERS_GENESYSLOGIC_GL9763E
    select DRIVERS_I2C_GENERIC
    select DRIVERS_I2C_HID
    select DRIVERS_I2C_SX9310
diff --git a/src/mainboard/google/volteer/variants/elemi/overridetree.cb b/src/mainboard/google/volteer/variants/elemi/overridetree.cb
index 4afc795..d4c40f9 100644
--- a/src/mainboard/google/volteer/variants/elemi/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/elemi/overridetree.cb
@@ -6,6 +6,13 @@
    register "IomTypeCPortPadCfg[0]" = "0x090E000A"
    register "IomTypeCPortPadCfg[1]" = "0x090E000D"

+        # Enable EMMC PCIE 5 using clk 5
+        register "PcieRpEnable[4]" = "1"
+        register "PcieRpLtrEnable[4]" = "1"
+        register "PcieRpHotPlug[4]" = "1"
+        register "PcieClkSrcUsage[5]" = "4"
+        register "PcieClkSrcClkReq[5]" = "5"
+
    #+-------------------+---------------------------+
    #| Field             |  Value                    |
    #+-------------------+---------------------------+
@@ -184,6 +191,7 @@
    			device generic 0 on end
    		end
    	end
+		device ref pcie_rp5 on end
    	device ref pmc hidden
    		# The pmc_mux chip driver is a placeholder for the
    		# PMC.MUX device in the ACPI hierarchy.