Attention is currently required from: Sean Rhodes, Stefan Reinauer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64485 )
Change subject: payloads/edk2: Add a recipe to build the ShimLayer
......................................................................
Patch Set 56:
(2 comments)
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/64485/comment/937e65bf_576aa389
PS56, Line 253: $(WORKSPACE)/Build/UniversalPayload.elf prep
Nit: indent an extra level to show that this is a continuation of the previous line.
https://review.coreboot.org/c/coreboot/+/64485/comment/5415415e_7c54d555
PS56, Line 254: ;
change to && instead of ; - this prevents the next commands from running if the 'cd' fails for some reason. Same on the cd, and possibly for the source commands below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I043271994f40813d9059a89420d4311d9d5802b1
Gerrit-Change-Number: 64485
Gerrit-PatchSet: 56
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 04 Sep 2022 16:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment