Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61631 )
Change subject: nb,soc/amd/*/iommu: fix comment about IOMMU MMIO resource ......................................................................
nb,soc/amd/*/iommu: fix comment about IOMMU MMIO resource
This comment was added with the AMD family 15h Trinity IOMMU support in commit 88ebbeb7e2a914330c869147bacb190b4270532f and looks like a copy of the comment about the subtractive decode ranges in the LPC device. The IOMMU doesn't have any subtractively decoded I/O or MMIO ranges and this is also not what the code does. This resource is the MMIO region to configure the IOMMU instead, so fix the comment in all copies of the IOMMU support code.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I2e1e3a46b839b9e58b836932c1bc9b41b1b1dc02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61631 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/northbridge/amd/agesa/family15tn/iommu.c M src/northbridge/amd/pi/00730F01/iommu.c M src/soc/amd/common/block/iommu/iommu.c 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/northbridge/amd/agesa/family15tn/iommu.c b/src/northbridge/amd/agesa/family15tn/iommu.c index 7af6538..587e737 100644 --- a/src/northbridge/amd/agesa/family15tn/iommu.c +++ b/src/northbridge/amd/agesa/family15tn/iommu.c @@ -13,7 +13,7 @@ /* Get the normal pci resources of this device */ pci_dev_read_resources(dev);
- /* Add an extra subtractive resource for both memory and I/O. */ + /* IOMMU MMIO registers */ res = new_resource(dev, 0x44); res->size = 512 * 1024; res->align = log2(res->size); diff --git a/src/northbridge/amd/pi/00730F01/iommu.c b/src/northbridge/amd/pi/00730F01/iommu.c index ef478dd..c79ddb5 100644 --- a/src/northbridge/amd/pi/00730F01/iommu.c +++ b/src/northbridge/amd/pi/00730F01/iommu.c @@ -12,7 +12,7 @@ /* Get the normal pci resources of this device */ pci_dev_read_resources(dev);
- /* Add an extra subtractive resource for both memory and I/O. */ + /* IOMMU MMIO registers */ res = new_resource(dev, 0x44); res->size = 512 * 1024; res->align = log2(res->size); diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index 67abe9e..9d4f38e 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -12,7 +12,7 @@ /* Get the normal pci resources of this device */ pci_dev_read_resources(dev);
- /* Add an extra subtractive resource for both memory and I/O. */ + /* IOMMU MMIO registers */ res = new_resource(dev, 0x44); res->size = 512 * KiB; res->align = log2(res->size);
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.