Change in ...coreboot[master]: mb/google/octopus/variants/meep: Disable xHCI compliance mode

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Chen Wisley (Code Review)

16 Jan 2019 16 Jan '19

9:32 a.m.

Hello Wisley Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/30948

to review the following change.

Change subject: mb/google/octopus/variants/meep: Disable xHCI compliance mode ......................................................................

mb/google/octopus/variants/meep: Disable xHCI compliance mode

Some usb devices exhibits signal loss which causes xHCI entering compliance mode. The resolution is to disable xHCI compliance mode.

BUG=b:122671995 TEST=check "Disable Link Compliance Mode" bit of "SuperSpeed Port Link control" register and usb operation successfully.

Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/meep/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/30948/1

diff --git a/src/mainboard/google/octopus/variants/meep/overridetree.cb b/src/mainboard/google/octopus/variants/meep/overridetree.cb index f531d13..f7aeac1 100644 --- a/src/mainboard/google/octopus/variants/meep/overridetree.cb +++ b/src/mainboard/google/octopus/variants/meep/overridetree.cb @@ -112,4 +112,7 @@ end end # - I2C 7 end + + # Disable compliance mode + register "DisableComplianceMode" = "1" end

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Paul Menzel (Code Review)

16 Jan 16 Jan

12:30 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30948 )

Change subject: mb/google/octopus/variants/meep: Disable xHCI compliance mode ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30948/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30948/1//COMMIT_MSG@9 PS1, Line 9: exhibits exhibit

https://review.coreboot.org/#/c/30948/1//COMMIT_MSG@13 PS1, Line 13: check "Disable Link Compliance Mode" bit of "SuperSpeed Port Link : control" register How did you check that? Is there a command?

-- To view, visit https://review.coreboot.org/c/coreboot/+/30948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Gerrit-Change-Number: 30948 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 16 Jan 2019 12:30:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

17 Jan 17 Jan

12:39 a.m.

Hello Karthik Ramasubramanian, Wisley Chen, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30948

to look at the new patch set (#2).

Change subject: mb/google/octopus/variants/meep: Disable xHCI compliance mode ......................................................................

mb/google/octopus/variants/meep: Disable xHCI compliance mode

Some usb devices exhibit signal loss which causes xHCI entering compliance mode. The resolution is to disable xHCI compliance mode.

BUG=b:122671995 TEST=check "Disable Link Compliance Mode" bit of "SuperSpeed Port Link control" register and usb operation successfully.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/30948/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Gerrit-Change-Number: 30948 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

12:39 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30948 )

Change subject: mb/google/octopus/variants/meep: Disable xHCI compliance mode ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/30948/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30948/1//COMMIT_MSG@9 PS1, Line 9: exhibits

...

exhibit

Done

https://review.coreboot.org/#/c/30948/1//COMMIT_MSG@13 PS1, Line 13: check "Disable Link Compliance Mode" bit of "SuperSpeed Port Link : control" register

...

How did you check that? Is there a command?

read the value of register via iotools => iotools mmio_read32 0xc11080ec

-- To view, visit https://review.coreboot.org/c/coreboot/+/30948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Gerrit-Change-Number: 30948 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 17 Jan 2019 00:39:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

18 Jan 18 Jan

6:44 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30948 )

Change subject: mb/google/octopus/variants/meep: Disable xHCI compliance mode ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Gerrit-Change-Number: 30948 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 18 Jan 2019 18:44:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Jan 20 Jan

9:04 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30948 )

Change subject: mb/google/octopus/variants/meep: Disable xHCI compliance mode ......................................................................

mb/google/octopus/variants/meep: Disable xHCI compliance mode

Some usb devices exhibit signal loss which causes xHCI entering compliance mode. The resolution is to disable xHCI compliance mode.

BUG=b:122671995 TEST=check "Disable Link Compliance Mode" bit of "SuperSpeed Port Link control" register and usb operation successfully.

Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/30948 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/meep/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/30948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ae7e52391fadc8ed23b8b76c45d410757d22ec Gerrit-Change-Number: 30948 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2139

days inactive

2143

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Chen Wisley (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)