Hello Frans Hendriks,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37611
to review the following change.
Change subject: mb/portwell/m107/acpi/superio.asl: Correct indent ......................................................................
mb/portwell/m107/acpi/superio.asl: Correct indent
Remove the additional tabs on all lines.
BUG=N/A TEST=build
Change-Id: I02b1314fe2ae89da3659b198c12df9c30c8a039d Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/portwell/m107/acpi/superio.asl 1 file changed, 20 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37611/1
diff --git a/src/mainboard/portwell/m107/acpi/superio.asl b/src/mainboard/portwell/m107/acpi/superio.asl index 309a26b..aecd174 100644 --- a/src/mainboard/portwell/m107/acpi/superio.asl +++ b/src/mainboard/portwell/m107/acpi/superio.asl @@ -15,30 +15,29 @@ * GNU General Public License for more details. */
+Device (COM1) { + Name (_HID, EISAID ("PNP0501")) + Name (_UID, 1)
- Device (COM1) { - Name (_HID, EISAID ("PNP0501")) - Name (_UID, 1) + Method (_STA, 0, NotSerialized) + { + Return (0x0F) + }
- Method (_STA, 0, NotSerialized) - { - Return (0x0F) - } + Name (_CRS, ResourceTemplate () + { + FixedIO (0x03F8, 0x08) + FixedIO (0x6E, 0x02) + IRQNoFlags () {4} + })
- Name (_CRS, ResourceTemplate () - { + Name (_PRS, ResourceTemplate () + { + StartDependentFn (0, 0) { FixedIO (0x03F8, 0x08) FixedIO (0x6E, 0x02) IRQNoFlags () {4} - }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - FixedIO (0x03F8, 0x08) - FixedIO (0x6E, 0x02) - IRQNoFlags () {4} - } - EndDependentFn () - }) - } + } + EndDependentFn () + }) +}
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37611 )
Change subject: mb/portwell/m107/acpi/superio.asl: Correct indent ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37611 )
Change subject: mb/portwell/m107/acpi/superio.asl: Correct indent ......................................................................
mb/portwell/m107/acpi/superio.asl: Correct indent
Remove the additional tabs on all lines.
BUG=N/A TEST=build
Change-Id: I02b1314fe2ae89da3659b198c12df9c30c8a039d Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37611 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/portwell/m107/acpi/superio.asl 1 file changed, 20 insertions(+), 21 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/portwell/m107/acpi/superio.asl b/src/mainboard/portwell/m107/acpi/superio.asl index 309a26b..aecd174 100644 --- a/src/mainboard/portwell/m107/acpi/superio.asl +++ b/src/mainboard/portwell/m107/acpi/superio.asl @@ -15,30 +15,29 @@ * GNU General Public License for more details. */
+Device (COM1) { + Name (_HID, EISAID ("PNP0501")) + Name (_UID, 1)
- Device (COM1) { - Name (_HID, EISAID ("PNP0501")) - Name (_UID, 1) + Method (_STA, 0, NotSerialized) + { + Return (0x0F) + }
- Method (_STA, 0, NotSerialized) - { - Return (0x0F) - } + Name (_CRS, ResourceTemplate () + { + FixedIO (0x03F8, 0x08) + FixedIO (0x6E, 0x02) + IRQNoFlags () {4} + })
- Name (_CRS, ResourceTemplate () - { + Name (_PRS, ResourceTemplate () + { + StartDependentFn (0, 0) { FixedIO (0x03F8, 0x08) FixedIO (0x6E, 0x02) IRQNoFlags () {4} - }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - FixedIO (0x03F8, 0x08) - FixedIO (0x6E, 0x02) - IRQNoFlags () {4} - } - EndDependentFn () - }) - } + } + EndDependentFn () + }) +}
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)