Attention is currently required from: Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, Morris Hsu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72775 )
Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72775/comment/9ae6862b_b7db3bb9 PS4, Line 7: SOLDERDOWN What is SOLDERDOWN?
File src/mainboard/google/brya/variants/constitution/memory.c:
https://review.coreboot.org/c/coreboot/+/72775/comment/e7ecb25a_7fbcd162 PS4, Line 14: /* Baseboard Rcomp target values */ Where did you get these from?
https://review.coreboot.org/c/coreboot/+/72775/comment/ac36c8df_ef96c44b PS4, Line 15: .targets = {40, 30, 30, 30, 30}, Below there is a space after { and before }.
https://review.coreboot.org/c/coreboot/+/72775/comment/88cdeec4_01282ebc PS4, Line 18: /* DQ byte map */ Where did you get these from? Please add the document number to the comment.
File src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/72775/comment/538cc641_87e513ca PS4, Line 8: MT53E1G32D2NP-046 WT:B 1 (0001) Please mention the parts (and vendor) in the commit message.
-
Paul Menzel (Code Review)