Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 81:
(4 comments)
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/su... PS74, Line 30: S5 resume
S5 or S3 resume?
We will do it in a follow-up.
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11ssh_flash.jpg:
PS74:
Maybe highlight the SOIC-16 flash chip on the top edge of the mainboard as well, with some text sayi […]
We will do it in a follow-up.
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 1: BOARD_SUPERMICRO_X11SSH_PLUS_TF : bool "X11SSH+-TF"
I don't see any 'X11SSH+-TF', so I'd remove the plus sign and "PLUS" from the Kconfig symbol name
We will do it in a follow-up.
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/bootblock.c:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 37: garbeled
garbled
We will do it in a follow-up.
-
Philipp Deppenwiese (Code Review)