[M] Change in coreboot[main]: drivers/spi/spi_flash_sfdp: add basic SFDP support

[Felix Held (Code Review)]

Attention is currently required from: Martin Roth, Matt DeVillier.

Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/84786?usp=email )

Change subject: drivers/spi/spi_flash_sfdp: add basic SFDP support
......................................................................

Patch Set 11:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84786/comment/6e7d0325_a5b8a97f?usp... :
PS10, Line 10:  a
             : specific
> Nit: Maybe you only tested on one chip, but this should work with any chip that supports this mechan […]

Done

File src/drivers/spi/spi_flash_sfdp.c:

https://review.coreboot.org/c/coreboot/+/84786/comment/9f1615d5_ade311b8?usp... :
PS10, Line 46: 0x50444653
> Nit: Use the ascii characters instead, or at least include them as a comment?

the cbmem ids also use hex numbers instead of char arrays; the byte order is also in reverse. i'll add a comment

https://review.coreboot.org/c/coreboot/+/84786/comment/2bd17df1_f39c0438?usp... :
PS10, Line 158: %#x
> %p?

it's an uint32_t, not an actual c pointer, so %#x is correct here

https://review.coreboot.org/c/coreboot/+/84786/comment/32a3c4ea_bb00e59f?usp... :
PS10, Line 176: if (get_sfdp_header(flash, &sfdp_rev, &param_header_count, &access_protocol) != CB_SUCCESS)
> Does this line need to be wrapped?

makes the code look a bit worse, but yes