Attention is currently required from: Tim Wawrzynczak, Reka Norman, Sridhar Siricilla, Balaji Manigandan, Krishna P Bhat D, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58679 )
Change subject: util/spd_tools: Add LP5 support for ADL
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
It’s been bothering me how ADL-specific this implementation is. E.g. […]
That's a good point. Given the spd tools are currently (AFAIK) customized around intel requirements, we probably should make that differentiation, perhaps move the current contents of util/spd_tools/src/ to util/spd_tools/src/intel/? Has the spd tool been used with AMD platforms, or just Intel? I'm not sure how different AMD requirements are.
re: "wait and see what other platforms do, and generalise the code as needed then"
I would agree that we should wait to add features until they are needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58679
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1e68d44f7c0ad64aa9904b7e1297d24bd5db56e
Gerrit-Change-Number: 58679
Gerrit-PatchSet: 8
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 03 Nov 2021 18:46:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment