Attention is currently required from: Jérémy Compostella, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84174?usp=email )
Change subject: src/include/cpu/x86: Add Extended Feature Enable Register Macro
......................................................................
Patch Set 4:
(2 comments)
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/84174/comment/784ac7c2_55d4a73b?usp... :
PS4, Line 64:
align with one more tab
https://review.coreboot.org/c/coreboot/+/84174/comment/2b353773_e70dbdd1?usp... :
PS4, Line 65: #define PWR_PERF_PLTFRM_OVR (1 << 18)
: #define VR_THERM_ALERT_DISABLE_LOCK (1 << 23)
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7be9a43a51bc52300e66cbf736c3e3275714b13b
Gerrit-Change-Number: 84174
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Sun, 01 Sep 2024 08:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No