Attention is currently required from: Paul Menzel, Angel Pons, Felix Held.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74904 )
Change subject: mb/purism/librem_cnl: Use EC BRAM bank 1 as CMOS memory bank 1 ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I reworked this patch set to use cmos.default to configure the auto power on setting in the EC BRAM. cmos.default can now span both bank 0 and bank 1, and the I/O base addresses for both can be configured (so Librem Mini can use the EC BRAM bank 1 while continuing to use the PCH for bank 0).
The only peculiarity is that I had to set up the EC BRAM bank 1 in bootblock now since cmos.default is applied in bootblock. This meant duplicating a bit of setup that the device tree would handle anyway, but it's not that much, and the cmos.default handling probably needs to stay in early bootblock for boards that actually have options used during boot (this one is not).