Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Dinesh Gehlot, Arthur Heymans, Eric Lai.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73278 )
Change subject: drivers/soundwire/max98363: Support MAX98363 SoundWire device
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
I am not familiar with SNDW, but any parameter could be override? If so, we should provide the entry […]
Here we are just exposing the capabilities of audio DB via ACPI. We do not modify/configure anything on the DB.
At platform level, we just need to supply the device location e.g.
`device generic 2.0 on end` where `2` is the LINK ID and `0` is the UID of the device.
File src/include/mipi/ids.h:
https://review.coreboot.org/c/coreboot/+/73278/comment/fbc8cdea_47b41964
PS3, Line 28: #define MIPI_DEV_ID_MAXIM_MAX98363 0x8363
why codec ID is under mipi folder.
Since these DBs are compliant with MIPI SoundWire spec defined by MIPI Alliance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie56109d615759e3e5e32782c8782cb2f47014ec4
Gerrit-Change-Number: 73278
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 19:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment