build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31493 )
Change subject: cbfstool: Add ifittool ......................................................................
Patch Set 9:
(21 comments)
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c File util/cbfstool/fit.c:
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@273 PS9, Line 273: if (!mcode_file) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@282 PS9, Line 282: ERROR("Couldn't allocate memory for microcode update entries.\n"); line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@392 PS9, Line 392: * bootblock, one Type 0x09 entry is needed to contain the failsafe hash. line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@531 PS9, Line 531: switch(fit->entries[i].type_checksum_valid) { switch and case should be at the same indent
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@531 PS9, Line 531: switch(fit->entries[i].type_checksum_valid) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@574 PS9, Line 574: fit_entry_size_bytes(&fit->entries[i]) ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@604 PS9, Line 604: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@647 PS9, Line 647: switch(type) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@773 PS9, Line 773: ERROR("No room, blob mcus = %zd, total entries = %d\n", line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c File util/cbfstool/ifittool.c:
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@85 PS9, Line 85: ERROR("Invalid topswap_size %zd, topswap can be 64K|128K|256K|512K|1M\n", line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@97 PS9, Line 97: static unsigned convert_to_from_absolute_top_aligned( Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@98 PS9, Line 98: const struct buffer *region, unsigned offset) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@113 PS9, Line 113: static unsigned convert_to_from_top_aligned(const struct buffer *region, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@114 PS9, Line 114: unsigned offset) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@122 PS9, Line 122: if ((offset > 0) && (offset < region->size)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@185 PS9, Line 185: ERROR("specified multiple operations at once\n"); line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@192 PS9, Line 192: ERROR("specified multiple operations at once\n"); line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@199 PS9, Line 199: ERROR("specified multiple operations at once\n"); line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@210 PS9, Line 210: ERROR("specified multiple operations at once\n"); line over 80 characters
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@224 PS9, Line 224: if (!*optarg || (suffix && *suffix)) { suspect code indent for conditional statements (24, 40)
https://review.coreboot.org/#/c/31493/9/util/cbfstool/ifittool.c@267 PS9, Line 267: ERROR("Adding FIT entry, but no CBFS file / region name given\n"); line over 80 characters