Change in coreboot[master]: mb/google/glados: port to FSP 2.0 - coreboot-gerrit

10 Oct 2019


      Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 )
Change subject: mb/google/glados: port to FSP 2.0
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados... 
File src/mainboard/google/glados/variants/chell/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados... 
PS4, Line 84: #| IccMax         | 7A        | 34A       | 35A         | 35A      |
...
outside of the scope of this patch, but it appears that chell is using the wrong IccMax values (usin […]
addressed this in a follow-on patch - CB:35958
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35921
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0
Gerrit-Change-Number: 35921
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Oct 2019 18:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: comment