Attention is currently required from: Tim Wawrzynczak. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55128 )
Change subject: src/mainboard: Add Star Labs labtop series ......................................................................
Patch Set 12:
(2 comments)
File Documentation/mainboard/starlabs/labtop.md:
https://review.coreboot.org/c/coreboot/+/55128/comment/2086b7de_47ae2093 PS9, Line 120: higher than **1.5.6** will work. : ![fwupd version](https://cdn.shopify.com/s/files/1/2059/5897/files/fwupdV.png?v=1611136423) : On Ubuntu 20.04, Ubuntu 20.10, Linux Mint 20.1 and elementaryOS 6, fwupd 1.5.6 can be installed from our PPA with the below terminal commands: :
sounds like you mean 1.5. […]
Done
File src/mainboard/starlabs/labtop/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/55128/comment/f1807a96_985991d2 PS9, Line 55:
Sorry I mean there's a tab between #define and EC_GPE_SWI, should be a space
Ack