Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Krystian Hebel, Matt DeVillier, Michał Żygowski, Raul Rangel, Sergii Dmytruk.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162?usp=email )
Change subject: security/tpm: support compiling in multiple TPM drivers
......................................................................
Patch Set 37:
(1 comment)
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/69162/comment/e91c9414_25b6d37a :
PS37, Line 46: RECORD_SIZE(tis_drivers)
This is a thing we could do but I think it feels a bit overkill for this use case? Especially with all the extra complication of how you need to define `__tis_driver`.
We only have a handful of TPM drivers anyway and we don't often add more, wouldn't a simple `if (CONFIG(DRIVER_X)) driver_x_probe()` list (like in `console_hw_init()`) suffice?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69162?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f
Gerrit-Change-Number: 69162
Gerrit-PatchSet: 37
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 Apr 2024 00:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment