Attention is currently required from: Martin L Roth, Subrata Banik, Paul Menzel.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71117 )
Change subject: soc/intel/common: Add API to check Key Locker support
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/71117/comment/33c8ae17_4ea3e9a4
PS7, Line 39: #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7
Use this macro?
Done
https://review.coreboot.org/c/coreboot/+/71117/comment/6b17ba7e_f61adaf8
PS7, Line 542: 0x7
Could you update this to use the CPUID_STRUCT_EXTENDED_FEATURE_FLAGS definition? […]
I will push separate patch to address this and apply to all function. For now marking these comments DONE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide9e59a4f11a63df48838eab02c2c584cced12e1
Gerrit-Change-Number: 71117
Gerrit-PatchSet: 7
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 03 Jan 2023 22:00:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment