Change in coreboot[master]: cpu/intel/model_106cx/Makefile.inc: Order entries

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44224 )


Change subject: cpu/intel/model_106cx/Makefile.inc: Order entries
......................................................................

cpu/intel/model_106cx/Makefile.inc: Order entries

Group lines by stages, then subdirs, then microcode. Within groups,
order in ascending count of `../` in prefix and then alphabetically.
Group CPU models separately from other subdirs, as they are special.

Tested with BUILD_TIMELESS=1, Intel D945GCLF remains identical.

Change-Id: I0aa6b46ae2f114fe1fa6b0a74669e09e142e2b05
Signed-off-by: Angel Pons <[e-mail]>
---
M src/cpu/intel/model_106cx/Makefile.inc
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44224/1

diff --git a/src/cpu/intel/model_106cx/Makefile.inc b/src/cpu/intel/model_106cx/Makefile.inc
index 6d8414e..8b1be1e 100644
--- a/src/cpu/intel/model_106cx/Makefile.inc
+++ b/src/cpu/intel/model_106cx/Makefile.inc
@@ -1,6 +1,7 @@
 ramstage-y += model_106cx_init.c
-subdirs-y += ../../x86/name
-subdirs-y += ../smm/gen1
 ramstage-$(CONFIG_PARALLEL_MP) += ../model_1067x/mp_init.c
 
+subdirs-y += ../smm/gen1
+subdirs-y += ../../x86/name
+
 cpu_microcode_bins += $(wildcard 3rdparty/intel-microcode/intel-ucode/06-1c-*)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0aa6b46ae2f114fe1fa6b0a74669e09e142e2b05
Gerrit-Change-Number: 44224
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/44224

to look at the new patch set (#3).

Change subject: cpu/intel/model_106cx/Makefile.inc: Order entries
......................................................................

cpu/intel/model_106cx/Makefile.inc: Order entries

Group lines by stages, then subdirs, then microcode. Within groups,
order in ascending count of `../` in prefix and then alphabetically.
Group CPU models separately from other subdirs, as they are special.

Tested with BUILD_TIMELESS=1, Intel D945GCLF remains identical.

Change-Id: I0aa6b46ae2f114fe1fa6b0a74669e09e142e2b05
Signed-off-by: Angel Pons <[e-mail]>
---
M src/cpu/intel/model_106cx/Makefile.inc
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44224/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0aa6b46ae2f114fe1fa6b0a74669e09e142e2b05
Gerrit-Change-Number: 44224
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44224 )

Change subject: cpu/intel/model_106cx/Makefile.inc: Order entries
......................................................................


Abandoned

Sorry, I ran out of patience and energy to care about these changes any longer.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0aa6b46ae2f114fe1fa6b0a74669e09e142e2b05
Gerrit-Change-Number: 44224
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon