Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55073 )
Change subject: cpu/x86/lapic: Add Kconfig choice LAPIC_ACCESS_MODE
......................................................................
Patch Set 2:
(1 comment)
File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/55073/comment/8988a5b1_0f3d70a1
PS2, Line 78: msr.lo |= LAPIC_BASE_MSR_X2APIC_MODE;
This is not always a valid change of mode. If the LAPIC_BASE_MSR_ENABLE bit is not set, this is invalid.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8269f9639ee3e89a2c2b4178d266ba2dac46db3f
Gerrit-Change-Number: 55073
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 04 Jun 2021 16:31:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment