Change in coreboot[master]: mb/google/hatch/variants: Update the touchscreen reset dealy to 200ms
Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Update the touchscreen reset dealy to 200ms ......................................................................
mb/google/hatch/variants: Update the touchscreen reset dealy to 200ms
Set the appropriate delay of 200ms between enable and reset for Goodix Touchscreen.
BUG=138413748 BRANCH=None TEST=Built and tested on Hatch system
Change-Id: I15005c568f285ec7bad9a0bec4498e2fdd20782b Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34626/1
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index e40a5664..fbd87b5 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -89,7 +89,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" + register "generic.reset_delay_ms" = "200" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" register "generic.enable_delay_ms" = "12"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Update the touchscreen reset dealy to 200ms ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@7 PS1, Line 7: Update Increase
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@7 PS1, Line 7: the The article could be left out in the summary line.
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@7 PS1, Line 7: dealy delay
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@9 PS1, Line 9: appropriate According to the datasheet? Did you experience problems?
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@10 PS1, Line 10: for Goodix Touchscreen. Please use the full text-width.
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@12 PS1, Line 12: BUG=138413748 Please summarize the bug report in the commit message, as not all people have access to it.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34626
to look at the new patch set (#2).
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
mb/google/hatch/variants: Increase touchscreen reset delay to 200ms
During boot sequence sometime touchscreen reset keeps failing. Also, kernel dmesg shows "dmesg:i2c_hid i2c-GDIX0000:00: failed to reset device" message. This adds around 4 more seconds to the boot sequence. Setting the appropriate delay of 200ms between enable and reset for Goodix Touchscreen helps to synchronize and address this failure.
BUG=138413748 BRANCH=None TEST=Built and tested on Hatch system
Change-Id: I15005c568f285ec7bad9a0bec4498e2fdd20782b Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34626/2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@7 PS1, Line 7: the
The article could be left out in the summary line.
Done
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@7 PS1, Line 7: Update
Increase
Ack
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@7 PS1, Line 7: dealy
delay
Ack
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@9 PS1, Line 9: appropriate
According to the datasheet? Did you experience problems?
I will add details on this current issue.
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@10 PS1, Line 10: for Goodix Touchscreen.
Please use the full text-width.
Ack
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@12 PS1, Line 12: BUG=138413748
Please summarize the bug report in the commit message, as not all people have access to it.
Ok
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2:
Where did the 200ms time come from?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2:
Kindly mark this WIP to avoid getting review.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2:
By Goodix spec, please change to 120ms.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2:
Sumeet - do you plan to update the reset delay to 120ms?
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 200ms ......................................................................
Patch Set 2:
Patch Set 2:
Sumeet - do you plan to update the reset delay to 120ms?
Yes, will submit this change.
Hello Aaron Durbin, Paul Fagerburg, Tim Wawrzynczak, Duncan Laurie, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34626
to look at the new patch set (#3).
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/variants: Increase touchscreen reset delay to 120ms
During boot sequence sometime touchscreen reset keeps failing. Also, kernel dmesg shows "dmesg:i2c_hid i2c-GDIX0000:00: failed to reset device" message. This adds around 4 more seconds to the boot sequence. Setting the appropriate delay of 120ms between enable and reset for Goodix Touchscreen helps to synchronize and address this failure. This value 120 ms as per Goodix Spec.
BUG=138413748 BRANCH=None TEST=Built and tested on Hatch system
Change-Id: I15005c568f285ec7bad9a0bec4498e2fdd20782b Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34626/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 3: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34626/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34626/3//COMMIT_MSG@13 PS3, Line 13: 1 is?
Hello Aaron Durbin, Paul Fagerburg, Subrata Banik, Tim Wawrzynczak, Duncan Laurie, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34626
to look at the new patch set (#4).
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/variants: Increase touchscreen reset delay to 120ms
During boot sequence sometime touchscreen reset keeps failing. Also, kernel dmesg shows "dmesg:i2c_hid i2c-GDIX0000:00: failed to reset device" message. This adds around 4 more seconds to the boot sequence. Setting the appropriate delay of 120ms between enable and reset for Goodix Touchscreen helps to synchronize and address this failure. This value is 120 ms as per Goodix Spec.
BUG=138413748 BRANCH=None TEST=Built and tested on Hatch system
Change-Id: I15005c568f285ec7bad9a0bec4498e2fdd20782b Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34626/4
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34626/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34626/3//COMMIT_MSG@13 PS3, Line 13: 1
is?
Ack
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 4: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 4: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34626/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34626/3//COMMIT_MSG@13 PS3, Line 13: 1
Ack
Done
Furquan Shaikh has uploaded a new patch set (#5) to the change originally created by Sumeet R Pawnikar. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/variants: Increase touchscreen reset delay to 120ms
During boot sequence sometime touchscreen reset keeps failing. Also, kernel dmesg shows "dmesg:i2c_hid i2c-GDIX0000:00: failed to reset device" message. This adds around 4 more seconds to the boot sequence. Setting the appropriate delay of 120ms between enable and reset for Goodix Touchscreen helps to synchronize and address this failure. This value is 120 ms as per Goodix Spec.
BUG=b:138413748 BRANCH=None TEST=Built and tested on Hatch system
Change-Id: I15005c568f285ec7bad9a0bec4498e2fdd20782b Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34626/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@9 PS1, Line 9: appropriate
I will add details on this current issue.
Done
https://review.coreboot.org/c/coreboot/+/34626/1//COMMIT_MSG@12 PS1, Line 12: BUG=138413748
Ok
Done
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34626 )
Change subject: mb/google/hatch/variants: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/variants: Increase touchscreen reset delay to 120ms
During boot sequence sometime touchscreen reset keeps failing. Also, kernel dmesg shows "dmesg:i2c_hid i2c-GDIX0000:00: failed to reset device" message. This adds around 4 more seconds to the boot sequence. Setting the appropriate delay of 120ms between enable and reset for Goodix Touchscreen helps to synchronize and address this failure. This value is 120 ms as per Goodix Spec.
BUG=b:138413748 BRANCH=None TEST=Built and tested on Hatch system
Change-Id: I15005c568f285ec7bad9a0bec4498e2fdd20782b Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34626 Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved V Sowmya: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index e40a5664..880d19f 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -89,7 +89,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" + register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" register "generic.enable_delay_ms" = "12"
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Tim Wawrzynczak (Code Review)
-
V Sowmya (Code Review)