[S] Change in coreboot[main]: soc/intel/common/block/fast_spi: probe for 2nd flash component

[Nico Huber (Code Review)]

Attention is currently required from: Maciej Pijanowski, Paul Menzel.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80608?usp=email )

Change subject: soc/intel/common/block/fast_spi: probe for 2nd flash component
......................................................................

Patch Set 4: Code-Review+1

(3 comments)

Patchset:

PS4: 
Code change looks ok. But I don't know why the code uses SFDP in general...

File src/soc/intel/common/block/fast_spi/fast_spi_def.h:

https://review.coreboot.org/c/coreboot/+/80608/comment/87a71010_ce0f62ac :
PS4, Line 156: #define SPIBAR_PTINX_IDX_MASK		0xffc
Why drop it?

File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

https://review.coreboot.org/c/coreboot/+/80608/comment/c6ad75c8_3d49ae1e :
PS4, Line 308:  * SFDP table. FLCOMP.C0DEN is no longer used by the Flash Controller.
This seems a little odd, the code was added in 2017. SPI guides up to
today still document C0DEN/C1DEN. Even state that they are used
to decide if VSCC0 or VSCC1 parameters should be used.

I guess it doesn't matter if the descriptor and SFDP report the same.
But if they don't, we'd have to know for sure which values are used
in hardware.

Flashprog seems happy to read the descriptor via FDO btw.

It looks like this was added in 2017 by CB:18557 which I can't access.
I couldn't find any document of that time that would match the reference
above.