Change in ...coreboot[master]: src/{include,security}: Use 'include <stdlib.h>' when appropriate
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33694
Change subject: src/{include,security}: Use 'include <stdlib.h>' when appropriate ......................................................................
src/{include,security}: Use 'include <stdlib.h>' when appropriate
Change-Id: I0b5c375baf7911ebced2f8c43a88aae014c877ad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/i2c_bus.h M src/security/tpm/tss/tcg-2.0/tss_marshaling.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/33694/1
diff --git a/src/include/device/i2c_bus.h b/src/include/device/i2c_bus.h index 6aa4f9b..0d8e049 100644 --- a/src/include/device/i2c_bus.h +++ b/src/include/device/i2c_bus.h @@ -14,7 +14,7 @@ #ifndef _DEVICE_I2C_BUS_H_ #define _DEVICE_I2C_BUS_H_
-#include <stdlib.h> +#include <stddef.h> #include <stdint.h> #include <device/i2c.h> #include <device/device.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index 21da73a..79021b7 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -7,11 +7,11 @@ #include <arch/early_variables.h> #include <commonlib/iobuf.h> #include <console/console.h> -#include <stdlib.h> +#include <stddef.h> #include <string.h> +#include <security/tpm/tss/vendor/cr50/cr50.h>
#include "tss_marshaling.h" -#include <security/tpm/tss/vendor/cr50/cr50.h>
static uint16_t tpm_tag CAR_GLOBAL; /* Depends on the command type. */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33694
to look at the new patch set (#4).
Change subject: src/{include,security}: Use 'include <stdlib.h>' when appropriate ......................................................................
src/{include,security}: Use 'include <stdlib.h>' when appropriate
Also including <types.h>, is supposed to provide stdint and stddef.
Change-Id: I0b5c375baf7911ebced2f8c43a88aae014c877ad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/i2c_bus.h M src/security/tpm/tss/tcg-2.0/tss_marshaling.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/33694/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33694 )
Change subject: src/{include,security}: Use 'include <stdlib.h>' when appropriate ......................................................................
Abandoned
see 32023
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33694 )
Change subject: src/{include,security}: Use 'include <stdlib.h>' when appropriate ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33694
to look at the new patch set (#5).
Change subject: src/security: Remove unused <stdlib.h> ......................................................................
src/security: Remove unused <stdlib.h>
Change-Id: I0b5c375baf7911ebced2f8c43a88aae014c877ad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/tpm/tspi/tspi.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/33694/5
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33694 )
Change subject: src/security: Remove unused <stdlib.h> ......................................................................
Patch Set 9: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33694 )
Change subject: src/security: Remove unused <stdlib.h> ......................................................................
src/security: Remove unused <stdlib.h>
Change-Id: I0b5c375baf7911ebced2f8c43a88aae014c877ad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33694 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/tpm/tspi/tspi.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/security/tpm/tspi/tspi.c b/src/security/tpm/tspi/tspi.c index 966b8b7..5fcf92d 100644 --- a/src/security/tpm/tspi/tspi.c +++ b/src/security/tpm/tspi/tspi.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <security/tpm/tspi.h> #include <security/tpm/tss.h> -#include <stdlib.h> #if CONFIG(VBOOT) #include <vb2_api.h> #include <vb2_sha.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index 720e7c4..48798c7 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -7,7 +7,6 @@
#include <commonlib/iobuf.h> #include <console/console.h> -#include <stdlib.h> #include <string.h>
#include "tss_marshaling.h" diff --git a/src/security/vboot/secdata_mock.c b/src/security/vboot/secdata_mock.c index a6c4afb..a4957f9 100644 --- a/src/security/vboot/secdata_mock.c +++ b/src/security/vboot/secdata_mock.c @@ -32,7 +32,6 @@ * stored in the TPM NVRAM. */
-#include <stdlib.h> #include <security/tpm/tspi.h> #include <vb2_api.h>
diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c index 0ce2136..96fac29 100644 --- a/src/security/vboot/secdata_tpm.c +++ b/src/security/vboot/secdata_tpm.c @@ -34,7 +34,6 @@
#include <security/vboot/antirollback.h> #include <security/vboot/tpm_common.h> -#include <stdlib.h> #include <string.h> #include <security/tpm/tspi.h> #include <vb2_api.h>
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)