Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47078 )
Change subject: HACK PATCH: sc7280: Comment out gpio and clock dependency ......................................................................
HACK PATCH: sc7280: Comment out gpio and clock dependency
As clock and gpio supports are not yet present in kodiak build, commenting out those inorder to compile QSPI driver.
Change-Id: I148a7bd7910a6d23cbec354fe88b35644a8716bf Signed-off-by: Roja Rani Yarubandi rojay@codeaurora.org --- M src/soc/qualcomm/sc7280/include/soc/qspi.h M src/soc/qualcomm/sc7280/qspi.c 2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/47078/1
diff --git a/src/soc/qualcomm/sc7280/include/soc/qspi.h b/src/soc/qualcomm/sc7280/include/soc/qspi.h index 6c40e7e..570a7cb 100644 --- a/src/soc/qualcomm/sc7280/include/soc/qspi.h +++ b/src/soc/qualcomm/sc7280/include/soc/qspi.h @@ -6,6 +6,8 @@ #ifndef __SOC_QUALCOMM_SC7280_QSPI_H__ #define __SOC_QUALCOMM_SC7280_QSPI_H__
+#define QSPI_BASE 0x088DC000 + struct sc7280_qspi_regs { u32 mstr_cfg; u32 ahb_mstr_cfg; diff --git a/src/soc/qualcomm/sc7280/qspi.c b/src/soc/qualcomm/sc7280/qspi.c index a6837bc..3c627a5 100644 --- a/src/soc/qualcomm/sc7280/qspi.c +++ b/src/soc/qualcomm/sc7280/qspi.c @@ -7,7 +7,7 @@ #include <soc/addressmap.h> #include <soc/qspi.h> #include <soc/gpio.h> -#include <soc/clock.h> +//#include <soc/clock.h> #include <symbols.h> #include <assert.h> #include <gpio.h> @@ -136,6 +136,7 @@ return next; }
+/* static void cs_change(enum cs_state state) { gpio_set(GPIO(15), state == CS_DEASSERT); @@ -154,6 +155,7 @@ gpio_configure(GPIO(14), GPIO14_FUNC_QSPI_CLK, GPIO_NO_PULL, GPIO_2MA, GPIO_OUTPUT_ENABLE); } +*/
static void queue_bounce_data(uint8_t *data, uint32_t data_bytes, enum qspi_mode data_mode, bool write) @@ -251,20 +253,20 @@ void quadspi_init(uint32_t hz) { assert(dcache_line_bytes() == CACHE_LINE_SIZE); - clock_configure_qspi(hz * 4); - configure_gpios(); +// clock_configure_qspi(hz * 4); +// configure_gpios(); reg_init(); }
int sc7280_claim_bus(const struct spi_slave *slave) { - cs_change(CS_ASSERT); +// cs_change(CS_ASSERT); return 0; }
void sc7280_release_bus(const struct spi_slave *slave) { - cs_change(CS_DEASSERT); +// cs_change(CS_DEASSERT); }
static int xfer(enum qspi_mode mode, const void *dout, size_t out_bytes,
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47078
to look at the new patch set (#2).
Change subject: HACK sc7280: Comment out gpio and clock dependency ......................................................................
HACK sc7280: Comment out gpio and clock dependency
As clock and gpio supports are not yet present in kodiak build, commenting out those inorder to compile QSPI driver.
Change-Id: I148a7bd7910a6d23cbec354fe88b35644a8716bf Signed-off-by: Roja Rani Yarubandi rojay@codeaurora.org --- M src/soc/qualcomm/sc7280/include/soc/qspi.h M src/soc/qualcomm/sc7280/qspi.c 2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/47078/2
Ravi Kumar Bokka has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47078 )
Change subject: HACK sc7280: Comment out gpio and clock dependency ......................................................................
Abandoned
-
Ravi kumar (Code Review) -
Ravi Kumar Bokka (Code Review)