Change in coreboot[master]: soc/intel/cmn/xhci: Add function to reset the XHCI controller - coreboot-gerrit

12 Apr 2022


      Attention is currently required from: Subrata Banik, Maulik V Vaghela, Sridhar Siricilla, Nick Vaccaro, Eric Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63551 )
Change subject: soc/intel/cmn/xhci: Add function to reset the XHCI controller
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/63551/comment/68af327e_2c060175 
PS3, Line 15: 
            : #define XHCI_USBCMD 0x80
            : #define  USBCMD_HCRST (1 << 1)
nit: align right side with tabs
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63551
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0dc0a64044f291893931726d26c08c8b964a3cc
Gerrit-Change-Number: 63551
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 19:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment