Attention is currently required from: Christian Walter, Angel Pons, Kyösti Mälkki, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54010 )
Change subject: cpu/x86/entry16.S: Make Intel CBnT TOCTOU safe
......................................................................
Patch Set 2:
(3 comments)
File src/include/cpu/intel/msr.h:
https://review.coreboot.org/c/coreboot/+/54010/comment/9a2b6025_5b31bcc4
PS2, Line 17:
For consistency with the other definitions, could you please indent these with tabs?
Done
https://review.coreboot.org/c/coreboot/+/54010/comment/1aecd798_fb17d15e
PS2, Line 18:
nit: the bitfield macros for the other MSRs have an additional space after `#define`
Done
https://review.coreboot.org/c/coreboot/+/54010/comment/1ebf1055_b6777fc0
PS2, Line 23: (1 << 32)
Isn't this shift undefined behavior?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54010
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2031e4e406655e14198e45f137ba152f8b6f567
Gerrit-Change-Number: 54010
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 12 May 2021 08:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment