Attention is currently required from: Reka Norman, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58929 )
Change subject: spd: Add new LP5 parts and generate SPDs
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Patchset:
PS3:
Thanks Reka!!
File spd/lp5/memory_parts.json:
https://review.coreboot.org/c/coreboot/+/58929/comment/33b56b5c_19122967
PS2, Line 19: 2,
I was basing this off Table 2 in the datasheet, which shows 2 ranks per channel. […]
Ack
https://review.coreboot.org/c/coreboot/+/58929/comment/3785de31_85ecbe40
PS2, Line 27: 4,
I know for LP4x there was one ZQ ball per die, so this was used as an indicator of the number of die […]
Ok, I took another look, and it does seem to line up with how you have it described here, thanks 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbcadfb78281b2b78a61a9b61180c421748193a0
Gerrit-Change-Number: 58929
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 05 Nov 2021 14:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment