Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31791
Change subject: util/intelmetool: Add support for Apollolake ......................................................................
util/intelmetool: Add support for Apollolake
Change-Id: I4f8ef88d2fcc4bff4e7f56fbe5199fb534ae66d1 Signed-off-by: Felix Singer felix.singer@9elements.com --- M util/intelmetool/intelmetool.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/31791/1
diff --git a/util/intelmetool/intelmetool.h b/util/intelmetool/intelmetool.h index 4c4dfcd..4d1103f 100644 --- a/util/intelmetool/intelmetool.h +++ b/util/intelmetool/intelmetool.h @@ -305,7 +305,8 @@ ((x) == PCI_DEVICE_ID_INTEL_WILDCAT_2) || \ ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H1) || \ ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_H2) || \ - ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP)) + ((x) == PCI_DEVICE_ID_INTEL_SUNRISE_LP) || \ + ((x) == PCI_DEVICE_ID_INTEL_APL))
#define BOOTGUARD_DISABLED 0x400000000 #define BOOTGUARD_ENABLED_VERIFIED_MODE 0x100000000
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31791 )
Change subject: util/intelmetool: Add support for Apollolake ......................................................................
Patch Set 1:
Do it in the previous CL?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31791 )
Change subject: util/intelmetool: Add support for Apollolake ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31791/1/util/intelmetool/intelmetool.h File util/intelmetool/intelmetool.h:
https://review.coreboot.org/#/c/31791/1/util/intelmetool/intelmetool.h@266 PS1, Line 266: #define PCI_DEV_HAS_SUPPORTED_ME(x) ( \ I'd not use this define as it's not a ME, but a TXE. Having PCI_DEV_HAS_SUPPORTED_TXE(x) would allow to probe for TXE.
For bootguard support you must also test if PCI_DEV_HAS_SUPPORTED_TXE() and version is >= 3.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31791 )
Change subject: util/intelmetool: Add support for Apollolake ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31791/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31791/1//COMMIT_MSG@7 PS1, Line 7: Apollolake Apollo Lake
https://review.coreboot.org/#/c/31791/1//COMMIT_MSG@8 PS1, Line 8: Tested on what device?
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31791 )
Change subject: util/intelmetool: Add support for Apollolake ......................................................................
Patch Set 1: Code-Review+2