Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: mb/ocp/tiogapass: Override SMBIOS data ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40308/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40308/14/src/mainboard/ocp/tiogapas... PS14, Line 33: const char *smbios_system_manufacturer(void)
Setting SMBIOS data is not OCP server specific. […]
CB:40309 is for lib code and allows platforms populate additional fields in the tables. So every platform has a choice to implement population of the fields to its hearts content.
However most (if not all) OCP platforms would share the code that populates fields based on commutation with BMC. So yeah this code needs to be shared by OCP platforms (as opposed every ocp motherboard reimplement same stuff all over again).
I was not aware vendorcode was intended for static code drops from vendors. So I think Patrick's idea is good, src/drivers/ocp sounds good for this code.
Did I already mention I am on a crusade to get rid of code copypaste ? ;)
-
Andrey Petrov (Code Review)