Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Julius Werner, Eric Peers, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56228 )
Change subject: soc/amd/common/block/lpc/spi_dma: Implement SPI DMA functionality ......................................................................
Patch Set 7: Code-Review+2
(4 comments)
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/56228/comment/ec72759a_fe9b5a96 PS5, Line 134: if (spi_dma_has_error())
Done. I didn't clear the error since we clear it before we start a new transaction.
Ack.
https://review.coreboot.org/c/coreboot/+/56228/comment/f0525772_145fd43c PS5, Line 173: udelay(10);
This is what I replied to Eric: […]
Ack.
https://review.coreboot.org/c/coreboot/+/56228/comment/7383316f_a2744501 PS5, Line 177: );
Since we are yielding control for an unknown amount of time, there is no easy way to know how long t […]
Ack.
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/56228/comment/986fdc9f_f73530c4 PS7, Line 101: We should have complete control over the DMA controller, so there shouldn't : * be any outstanding transactions. Based on the comment you added on line 230, can there ever be a scenario that PSP decides to use the SPI DMA for any purpose while x86 is booting up? Just wondering if this should be an assert or if it should be a busy-wait so that x86 can take control once PSP is done.