Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email )
Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80923/comment/77a9d4a0_f9da0dbc : PS3, Line 99: $(foreach index,$(INDEXES), \ : $(shell dd if=$(INPUT_FILE) of=$(TEMP_FILE) bs=1 skip=$(word $(index),$(OFFSETS)) count=2 status=none) \ : $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_FILE)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_FILE)) | cut -c1-2))) ) \ : ) : rm -f $(TEMP_FILE) : $(eval CSE_RW_CBFS_VERSION := $(shell printf "%d.%d.%d.%d" $(CSE_VERSION_MAJOR)$(CSE_VERSION_MINOR)$(CSE_VERSION_HOTFIX)$(CSE_VERSION_BUILD)))
It can be reduced to `hexdump -s 16 -n 8 -e '4/2 "%d."' $(INPUT_FILE) | sed 's/.$//'`
can you please submit an incremental CL?