[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Select more appropriate macros for USB ports

[Sean Rhodes (Code Review)]

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85974?usp=email )

(

8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: mb/starlabs/starlite_adl: Select more appropriate macros for USB ports
......................................................................

mb/starlabs/starlite_adl: Select more appropriate macros for USB ports

Add the trace lengths as comments, and update the macros used for the
USB ports accordingly.

Like other boards, avoid the `USB2_PORT_TYPE_C` macro, as it makes
ports behave inconsistantly.

Change-Id: Id193b3ed86c58aedc7d5a1f384f2829a2bf18671
Signed-off-by: Sean Rhodes 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85974
Reviewed-by: Matt DeVillier 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
index 8c87eff..cca6059 100644
--- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
+++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
@@ -49,22 +49,22 @@
    	end
    	device ref gna		on  end
    	device ref xhci		on
-			# Bottom USB 3.0 Type-C
-			register "usb2_ports[0]"			= "USB2_PORT_MID(OC_SKIP)"
+			# Bottom USB 3.0 Type-C				3289 mil
+			register "usb2_ports[0]"			= "USB2_PORT_SHORT(OC_SKIP)"
    		register "usb3_ports[2]"			= "USB3_PORT_DEFAULT(OC_SKIP)"

-			# Top USB 3.0 Type-C
-			register "usb2_ports[1]"			= "USB2_PORT_MID(OC_SKIP)"
+			# Top USB 3.0 Type-C				4237 mil
+			register "usb2_ports[1]"			= "USB2_PORT_SHORT(OC_SKIP)"
    		register "usb3_ports[0]"			= "USB3_PORT_DEFAULT(OC_SKIP)"

-			# Detachable Keyboard + SD Card Reader
-			register "usb2_ports[2]"			= "USB2_PORT_MID(OC_SKIP)"
+			# Detachable Keyboard + SD Card Reader		6418 mil
+			register "usb2_ports[2]"			= "USB2_PORT_SHORT(OC_SKIP)"

-			# Camera + Webcam
-			register "usb2_ports[CONFIG_CCD_PORT]"		= "USB2_PORT_MID(OC_SKIP)"
+			# Camera + Webcam				3249 mil
+			register "usb2_ports[CONFIG_CCD_PORT]"		= "USB2_PORT_SHORT(OC_SKIP)"

-			# Internal Bluetooth
-			register "usb2_ports[9]"			= "USB2_PORT_MID(OC_SKIP)"
+			# Internal Bluetooth				1874 mil
+			register "usb2_ports[9]"			= "USB2_PORT_SHORT(OC_SKIP)"

chip drivers/usb/acpi
    			device ref xhci_root_hub on