Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85654?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB support
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8196/gpueb.c:
https://review.coreboot.org/c/coreboot/+/85654/comment/266bd7e1_f8856bae?usp... :
PS2, Line 305: write32p(GPUEB_INFO, (uintptr_t)mcu->load_buffer);
: write32p(GPUEB_ABNORMAL_BOOT, 0);
: write32p(GPUEB_WARM_BOOT, 0);
: write32p(GPUMPU_RSV_ADDR, (uintptr_t)_resv_mem_gpueb >> PAGE_SHIFT);
Can you explain this part ? I don't quite understand why it writes `mcu->load_buffer` to `GPUEB_INFO`. `mcu->load_buffer` is pointing to a shared DMA buffer. Will GPUEB HW copy the content of `mcu->load_buffer` to somewhere ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f10dfc753f73df97ea08a4c23e97de416832be2
Gerrit-Change-Number: 85654
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 19 Dec 2024 13:23:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No