Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35886 )
Change subject: [TESTME]soc/intel/icelake: Properly select PCIEX_LENGTH_64MB
......................................................................
Patch Set 2:
Patch Set 2:
Arthur,
In ICL and CNL we are having CONFIG_SA_PCIEX_LENGTH=0x10000000 (256MB)
this is as per CNL programming guide we need to set PCIEX to 256MB
if you can select PCIEX_LENGTH_256MB from CNL/ICL then we are good as i could see you are planning to remove the default value as 256MB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I203059ed606fb56b069a382bed449abf311b81c1
Gerrit-Change-Number: 35886
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 05:31:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment