Attention is currently required from: Mario Scheithauer, Jan Samek.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks ......................................................................
Patch Set 1:
(2 comments)
File src/drivers/i2c/rv3028c7/chip.h:
https://review.coreboot.org/c/coreboot/+/69543/comment/6aab3a3e_06e61f19 PS1, Line 38: unsigned int bus_speed; /* Bus clock in Hz (default 400 kHz) */
I'm in doubt here whether this default is the "datasheet default" or the default in rv3028c7. […]
The term 'default' here means the default speed the DW-I2C controller uses. In dw_i2c.c there is a code line like this:
speed = bcfg->speed ? : I2C_SPEED_FAST;
So if there is no dedicated bus speed assigned, it will default to 400 kHz. This comment more or less tries to bring this into attention though it is DW-I2C related..
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/69543/comment/c52b2e4b_4a3adf3f PS1, Line 197: bus_speed = I2C_SPEED_STANDARD;
... […]
Yes, fall back to lowest possible mode to ensure bus stability in case of doubt. If the user needs a higher speed, one can provide it in devicetree.
-
Werner Zeh (Code Review)